Skip to content

Fix issues with back/forward and pathbar navigation in ColumnView #7504

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Jan 13, 2022
Merged

Fix issues with back/forward and pathbar navigation in ColumnView #7504

merged 9 commits into from
Jan 13, 2022

Conversation

gave92
Copy link
Member

@gave92 gave92 commented Jan 8, 2022 •
edited
Loading

Resolved / Related Issues
Items resolved / related issues by this PR.

  • Closes Cannot rename files properly in column layout #7522
  • Fixes Appcenter 2452523060u (crash on back button after navigating away from column view)
  • Fixed an issue where using the drop downs or manually typing in the path bar would navigate in the current column
  • Fixed an issue where after going back from search the column did not open folders
  • Fixed an issue where you could not go back after searching in a column

Notes

  • Code in Back_Click() and Forward_Click() was wrongly removed in Improve keyboard nav in column layout #7494, added back verbatim
  • Added call to dispose when navigating away from column view to unsubscribe from events (2452523060u)

Validation
How did you test these changes?

  • Built and ran the app

@yaira2 yaira2 requested a review from BanCrash January 8, 2022 23:48
yaira2
yaira2 previously approved these changes Jan 9, 2022
View reviewed changes
@gave92
Copy link
Member Author

gave92 commented Jan 9, 2022 •
edited
Loading

Latest commit fixes the renaming issues in Column View:

  • Typing while renaming does not cancel renaming
  • Clicking twice on a folder now starts renaming

@gave92 gave92 marked this pull request as draft January 9, 2022 11:17
@gave92 gave92 marked this pull request as ready for review January 9, 2022 11:42
@gave92 gave92 marked this pull request as draft January 10, 2022 23:19
@gave92 gave92 marked this pull request as ready for review January 11, 2022 00:16
@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed needs - code review labels Jan 13, 2022
@yaira2 yaira2 merged commit b979b26 into files-community:main Jan 13, 2022
@yaira2 yaira2 mentioned this pull request Jan 13, 2022
Closed
@gave92 gave92 deleted the column branch January 13, 2022 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yaira2 yaira2 yaira2 approved these changes

@BanCrash BanCrash Awaiting requested review from BanCrash

Assignees
No one assigned
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot rename files properly in column layout
2 participants
@gave92 @yaira2