Skip to content

Auto refresh files and folders #79

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 8, 2019
Merged

Auto refresh files and folders #79

merged 4 commits into from
Mar 8, 2019

Conversation

ashikns
Copy link
Contributor

@ashikns ashikns commented Mar 6, 2019

This PR aims to fix #6, fix #55.Filesystem changes will be automatically reflected. There are also some code refactors, some were necessary others are just good practices like reducing publicly accessible things.

Performance is good enough for a moderately sized folder. However it's not optimal. There are two broad changes that can be made to improve performance (not just for auto refresh but in general):

  1. Expose files and folders as separate lists. UWP treats file and folder as very different types and provides separate api to work with them so it makes sense to split them in the code as well.
  2. Use a different observable collection like dictionary or hashset. Of course these don't exist by default so we'll have to write one ourselves.

@yaira2
Copy link
Member

yaira2 commented Mar 6, 2019

Great job!

@ashikns
Copy link
Contributor Author

ashikns commented Mar 7, 2019

@duke7553 while testing please keep an eye on the ui to see if any bindings are broken. I don't get along well with xaml bindings -_-

@lukeblevins
Copy link
Contributor

LGTM; Very good work, by the way

@lukeblevins lukeblevins merged commit b2328c0 into files-community:master Mar 8, 2019
@ashikns ashikns deleted the auto-refresh branch March 10, 2019 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sometimes, clicking "back" or "forward" during the load of a large directory will include an item from the previous folder in the new one
3 participants