Skip to content

Alert the user when trying to delete a file which is in use #862

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
May 31, 2020
Merged

Alert the user when trying to delete a file which is in use #862

merged 8 commits into from
May 31, 2020

Conversation

jaigak
Copy link
Contributor

@jaigak jaigak commented May 27, 2020

Fix #221

@yaira2
Copy link
Member

yaira2 commented May 27, 2020

@Jaiganeshkumaran Can you open a separate pull request with the translation updates?

@jaigak
Copy link
Contributor Author

jaigak commented May 27, 2020

@Jaiganeshkumaran Can you open a separate pull request with the translation updates?

I did the translation in the same pull request by mistake. I will open another pull request.

@yaira2
Copy link
Member

yaira2 commented May 28, 2020

@Jaiganeshkumaran Can you install the MAT extension so that it generates the resource files for the strings you added?

Copy link
Contributor

@lukeblevins lukeblevins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lukeblevins lukeblevins added ready to merge Pull requests that are approved and ready to merge and removed needs - code review labels May 29, 2020
@yaira2 yaira2 merged commit 6fbfa59 into files-community:master May 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Alert user trying to delete an open file.
3 participants