Skip to content

Updated Nuget packages #890

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 1, 2020
Merged

Updated Nuget packages #890

merged 2 commits into from
Jun 1, 2020

Conversation

yaira2
Copy link
Member

@yaira2 yaira2 commented Jun 1, 2020

No description provided.

gave92
gave92 reviewed Jun 1, 2020
View reviewed changes
Copy link
Member

@gave92 gave92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm seeing that I mistakenly added the Microsoft.Net.Compilers dependency. I needed that to build the project with Visual Studio 2017 (to get C# 8 compatibility). You have no reason to keep it. I apologize.

@yaira2
Copy link
Member Author

yaira2 commented Jun 1, 2020

@gave92 Can you remove that in a separate pull request?

@gave92
Copy link
Member

gave92 commented Jun 1, 2020 •
edited
Loading

Ok I'll do that: #892

@yaira2
Copy link
Member Author

yaira2 commented Jun 1, 2020

@gave92 Thank you.

@lukeblevins lukeblevins self-requested a review June 1, 2020 01:41
@yaira2 yaira2 merged commit c5d3e10 into master Jun 1, 2020
@yaira2 yaira2 deleted the UpdatedNugetPackages branch June 1, 2020 01:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
2 more reviewers

@gave92 gave92 gave92 left review comments

@lukeblevins lukeblevins lukeblevins approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yaira2 @gave92 @lukeblevins