Skip to content

Conversation

yaira2
Copy link
Member

@yaira2 yaira2 commented Jun 4, 2020

No description provided.

@yaira2 yaira2 requested review from lukeblevins and tsvietOK June 4, 2020 04:45
@tsvietOK
Copy link
Contributor

tsvietOK commented Jun 4, 2020

Did you try to use FindPackageForUser?

@yaira2
Copy link
Member Author

yaira2 commented Jun 4, 2020

@tsvietOK That is a restricted capability and the store didn't certify our app to use that capability.

@tsvietOK
Copy link
Contributor

tsvietOK commented Jun 4, 2020

I have found a bug.
Repro:
Revert this patch.
Copy this json to terminal.json

{
  "version": 1,
  "terminals": [
    {
      "id": 1,
      "name": "CMD",
      "path": "cmd.exe",
      "arguments": "/k \"cd /d {0} && title Command Prompt\"",
      "icon": ""
    },
    {
      "id": 2,
      "name": "Windows PowerShell",
      "path": "powershell.exe",
      "arguments": "-WorkingDirectory \"{0}\"",
      "icon": ""
    },
    {
      "id": 3,
      "name": "Windows Terminal",
      "path": "wt.exe",
      "arguments": "-d \"{0}\"",
      "icon": ""
    }
  ]
}

Restart app
Set default terminal Windows Terminal.
Close app
Apply this patch.
Start app and try to open terminal in folder.
Crash.
That happen because of localSettings terminal_id store old terminal id value = 3. But current updated terminal.json contain only two items.
So i would suggest to save default terminal id right in terminal.json file.
Edit: Additionally you can't open terminals settings page

@yaira2 yaira2 merged commit 99baacc into master Jun 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants