Skip to content

Refactor FileSystem #9030

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 3, 2022
Merged

Refactor FileSystem #9030

merged 2 commits into from
May 3, 2022

Conversation

cinqmilleans
Copy link
Contributor

Here is a new batch of refactoring. I added ILogger as a service to eliminate dependency to App.

Validation
How did you test these changes?

  • Built and ran the app
  • Tested the changes for accessibility

@yaira2 yaira2 requested a review from BanCrash April 29, 2022 14:01
BanCrash
BanCrash approved these changes May 3, 2022
View reviewed changes
Copy link
Contributor

@BanCrash BanCrash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BanCrash BanCrash added ready to merge Pull requests that are approved and ready to merge and removed needs - code review labels May 3, 2022
@yaira2 yaira2 merged commit 10eb885 into files-community:main May 3, 2022
@cinqmilleans
Copy link
Contributor Author

@BanCrash Thank you very much for your review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@BanCrash BanCrash BanCrash approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cinqmilleans @BanCrash @yaira2