Service IDateTimeFormatter #9053
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@BanCrash I made a small style change. |
yaira2
added
ready to merge
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace DateTimeExtensions by service IDateTimeFormatter.
This pr is a refactor that profoundly changes the structure of date formatting. This pr releases ListedItem from this coupling to prepare its refactoring.
Resolved / Related Issues
DateTimeExtensions is a design issue: static class that exposes unused methods, difficult to add/modify a date format because everything is done in the same implementation, use of returnFormat as constructor parameter of many classes that shouldn't fit care about it, public method that returns 4 values in a tuple, read user parameters on each call.
Details of Changes
This pr creates a new IDateTimeFormatter service and its 3 user parameter implementations, and an implementation (provided by IServiceProvider) that still behaves like the user format.
DateTimeExtensions is removed.
All uses of returnFormat are removed. The other classes don't have to worry about it.
Use an event to change format.
The initialisation of the setting windows is simpler because of inheritance.
Validation
How did you test these changes?