Skip to content

Fix dropping from 7zip to folder #9063

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 1, 2022
Merged

Fix dropping from 7zip to folder #9063

merged 1 commit into from
May 1, 2022

Conversation

gave92
Copy link
Member

@gave92 gave92 commented May 1, 2022 •
edited
Loading

Resolved / Related Issues
Items resolved / related issues by this PR.

  • Fixes an issue preventing to drag&drop from 7zip/WinRar/etc to a folder in Files (dropping to the empty space already works, but not dropping into a folder)

Details of Changes
Add details of changes here.

  • Match DragOver() if-checks to Item_DragOver(). The handledByFtp condition must be checked before draggedItems.Any().

Validation
How did you test these changes?

  • Built and ran the app

@gave92 gave92 marked this pull request as ready for review May 1, 2022 20:00
@gave92 gave92 changed the title Fix dropping from zip to folder Fix dropping from 7zip to folder May 1, 2022
yaira2
yaira2 approved these changes May 1, 2022
View reviewed changes
Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 merged commit ab08c2d into files-community:main May 1, 2022
@yaira2 yaira2 added the ready to merge Pull requests that are approved and ready to merge label May 1, 2022
@gave92 gave92 deleted the drop_folder branch May 1, 2022 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yaira2 yaira2 yaira2 approved these changes

Assignees
No one assigned
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gave92 @yaira2