Skip to content

Avoid favorite sidebar constant reloading #9065

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 2, 2022
Merged

Avoid favorite sidebar constant reloading #9065

merged 2 commits into from
May 2, 2022

Conversation

gave92
Copy link
Member

@gave92 gave92 commented May 1, 2022 •
edited
Loading

Resolved / Related Issues
Items resolved / related issues by this PR.

Details of Changes
Add details of changes here.

  • Avoid reloading favorites sidebar items if the config file contents have not changed
  • Code taken from TerminalController.cs

Validation
How did you test these changes?

  • Built and ran the app

@gave92 gave92 requested a review from BanCrash May 1, 2022 22:20
@gave92 gave92 marked this pull request as draft May 1, 2022 22:22
@gave92 gave92 marked this pull request as ready for review May 1, 2022 22:24
BanCrash
BanCrash approved these changes May 2, 2022
View reviewed changes
Copy link
Contributor

@BanCrash BanCrash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, that was fast, gj! LGTM

@BanCrash BanCrash added ready to merge Pull requests that are approved and ready to merge and removed needs - code review labels May 2, 2022
@yaira2 yaira2 merged commit e2b0e12 into files-community:main May 2, 2022
@gave92 gave92 deleted the issue_9022 branch May 2, 2022 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@BanCrash BanCrash BanCrash approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Favorite sidebar list reloads often for no reason
3 participants
@gave92 @BanCrash @yaira2