Skip to content

Conversation

cinqmilleans
Copy link
Contributor

@cinqmilleans cinqmilleans commented May 4, 2022

Resolved / Related Issues
When the option is activated, the deletion confirmation dialog is not displayed when deleting an element by drag&drop to the Recycle Bin. #8649

Details of Changes
The confirmation dialog is displayed (if the option is activated) during a drag&drop to the Recycle Bin.
Works with sidebar and dual panel.

Validation
How did you test these changes?

  • Built and ran the app
  • Tested the changes for accessibility

Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@yaira2 yaira2 added the ready to merge Pull requests that are approved and ready to merge label May 4, 2022
@yaira2 yaira2 changed the title Fix drop to recycle bin Fixed an issue where the confirm delete dialog didn't display when dragging an item to recycle bin May 4, 2022
@yaira2 yaira2 merged commit 2ea2799 into files-community:main May 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants