Skip to content

fix(sidebar): add items to favorites in a consistent order #9113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 8, 2022
Merged

fix(sidebar): add items to favorites in a consistent order #9113

merged 2 commits into from
May 8, 2022

Conversation

jiejasonliu
Copy link
Contributor

Resolved / Related Issues

Details of Changes

  • Make adds to SidebarItems (model) and sidebarList (UI list) atomic (otherwise model and UI desync)
  • Eliminate unnecessary refreshes by serializing model to configContent after every save
    • suppressChangeEvent wasn't a good solution; Query_ContentChanged could be handled very late after many saves
  • Refactor AddItemToSidebarAsync to reuse existing methods

Validation

  • Built and ran the app
  • Tested the changes for accessibility

Screenshots (optional)

(notice how add order is consistent instead of random)
Files-8941

@yaira2 yaira2 requested a review from gave92 May 8, 2022 02:04
gave92
gave92 approved these changes May 8, 2022
View reviewed changes
Copy link
Member

@gave92 gave92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks!

@gave92 gave92 added ready to merge Pull requests that are approved and ready to merge and removed needs - code review labels May 8, 2022
@yaira2 yaira2 merged commit 50f5ab8 into files-community:main May 8, 2022
@yaira2 yaira2 mentioned this pull request May 8, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@gave92 gave92 gave92 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Item disappearing from the favorite section
3 participants
@jiejasonliu @gave92 @yaira2