Fix up button #9228
Merged
Fix up button #9228
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gave92
approved these changes
May 21, 2022
gave92
added
the
ready to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved / Related Issues
Drive roots use a path such as "C:\". This is the path that is used when opening a drive from the sidebar or other. But when the Up button needs to return to C:\, it actually calls C:, it's that path in the address bar.
This leads to not finding the drive, for example when we want to display the properties of the disk.
Closes #9227
Details of Changes
This pr modifies the Up_Click method to add the trailing "\" when the path ends with ":". This character is forbidden in paths, except to indicate the drive.
Validation
How did you test these changes?