Skip to content

Improve cloud drives detection speed #9230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 22, 2022
Merged

Improve cloud drives detection speed #9230

merged 1 commit into from
May 22, 2022

Conversation

gave92
Copy link
Member

@gave92 gave92 commented May 21, 2022 •
edited
Loading

Resolved / Related Issues
Items resolved / related issues by this PR.

  • Improve cloud drives detection speed. Cloud drives section appears faster on startup.

Details of Changes
Add details of changes here.

  • Loop over Namespace subkeys instead of CLSID subkeys. There are a lot less keys under Namespace.

Validation
How did you test these changes?

  • Built and ran the app

@lukeblevins lukeblevins self-requested a review May 22, 2022 01:37
lukeblevins
lukeblevins approved these changes May 22, 2022
View reviewed changes
Copy link
Contributor

@lukeblevins lukeblevins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good find!

yaira2
yaira2 approved these changes May 22, 2022
View reviewed changes
Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 added the ready to merge Pull requests that are approved and ready to merge label May 22, 2022
@yaira2 yaira2 merged commit fb9afd4 into files-community:main May 22, 2022
@gave92 gave92 deleted the cloud_fast branch May 22, 2022 05:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yaira2 yaira2 yaira2 approved these changes

+1 more reviewer

@lukeblevins lukeblevins lukeblevins approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gave92 @lukeblevins @yaira2