Set downloads folder to group by date

[esibruti]

Resolved / Related Issues
Items resolved / related issues by this PR.

• Closes Set downloads folder to group by date #6586

Details of Changes
Add details of changes here.

• With this code, the Downloads folder will be grouped by date modified on the first start.

Validation
How did you test these changes?

• Built and ran the app
• Tested the changes for accessibility

[gave92]

We already have this logic in FolderSettingsViewModel 🤔

​            ​else​ ​if​ (​folderPath​ ​==​ ​CommonPaths​.​DownloadsPath​) 
​            { 
​                ​//​ Default for downloads folder is to group by date created 
​                ​return​ ​new​ ​LayoutPreferences 
​                { 
​                    ​...
​                    ​DirectoryGroupOption​ ​=​ ​GroupOption​.​DateCreated​, 
​                }; 
​            }

Doing it in ItemsViewModel would stop the user from changing it to something else.

[esibruti]

@gave92 I hadn't even noticed it 😅
So but that means that the issue was already resolved before... Now I'm confused.

[gave92]

Lol confused as well as to why that issue exists 😆 Could be there's an issue preventing it to work. Problem is you only notice it if you've never ever changed the layout/sorting in Downloads folder. Reinstalling Files may not reset it so it's not easy to test.

[gave92]

Aaah found the issue, indeed that logic does not work. That's because we're passing a wrong path to be compared with the downloads folder path: ReadLayoutPreferencesFromSettings(folderPath.TrimEnd('\\').Replace('\\', '_') Ln355 -> We're triyng to compare C:_Users_USER_Downloads to C:\Users\USER\Downloads.

[esibruti]

Aaah found the issue, indeed that logic does not work. That's because we're passing a wrong path to be compared with the downloads folder path: ReadLayoutPreferencesFromSettings(folderPath.TrimEnd('\\').Replace('\\', '_') Ln355 -> We're triyng to compare C:_Users_USER_Downloads to C:\Users\USER\Downloads.

So the solution is to remove this replace or replace with '/'?

[gave92]

So changing "\" with "_" is done for a reason, that is LocalSettings throw error if you try to use a key/setting name that contains "\". We need to separate "ReadLayoutPreferencesFromSettings" which reads from LocalSettings and should use the paths with "_" from getting the default layout part that should use the "normal" path.

[esibruti]

But that means on line 355 it should be comparing with the '\' instead of the '_', right?

[esibruti]

@gave92 When you can, do the review, I think I found the solution.