Skip to content

Do not load quick access icon #9265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 25, 2022
Merged

Do not load quick access icon #9265

merged 1 commit into from
May 25, 2022

Conversation

gave92
Copy link
Member

@gave92 gave92 commented May 25, 2022 •
edited
Loading

Resolved / Related Issues
Items resolved / related issues by this PR.

  • Not a bug fix, just a small optimization

Details of Changes
Add details of changes here.

  • Since we now use a custom icon for the favorites section, there's no need to load the quick access icon from shell32 dll on start.

Validation
How did you test these changes?

  • Built and ran the app

yaira2
yaira2 approved these changes May 25, 2022
View reviewed changes
Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@yaira2 yaira2 added the ready to merge Pull requests that are approved and ready to merge label May 25, 2022
@yaira2 yaira2 merged commit 9ed536a into files-community:main May 25, 2022
@gave92 gave92 deleted the rem_shell32 branch May 25, 2022 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yaira2 yaira2 yaira2 approved these changes

Assignees
No one assigned
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gave92 @yaira2