Skip to content

Fix issue causing user settings to be repeatedly reloaded from file in some cases #9669

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 7, 2022
Merged

Fix issue causing user settings to be repeatedly reloaded from file in some cases #9669

merged 2 commits into from
Aug 7, 2022

Conversation

gave92
Copy link
Member

@gave92 gave92 commented Aug 7, 2022

Details of Changes
Add details of changes here.

  • Fixed an issue causing settings to be repeatedly read from file in some cases
  • Moved public SemaphoreSlim from App.cs to StorageHistoryHelpers (only place it's used)

Validation
How did you test these changes?

  • Built and ran the app

@gave92 gave92 marked this pull request as ready for review August 7, 2022 14:45
yaira2
yaira2 approved these changes Aug 7, 2022
View reviewed changes
Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 added the ready to merge Pull requests that are approved and ready to merge label Aug 7, 2022
@yaira2 yaira2 merged commit b33ceff into files-community:main Aug 7, 2022
@gave92 gave92 deleted the perfo branch August 7, 2022 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yaira2 yaira2 yaira2 approved these changes

Assignees
No one assigned
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gave92 @yaira2