Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

5275 set multiple images as desktop background #9712

Merged
merged 10 commits into from Aug 16, 2022
Merged

5275 set multiple images as desktop background #9712

merged 10 commits into from Aug 16, 2022

Conversation

QuaintMako
Copy link
Contributor

@QuaintMako QuaintMako commented Aug 12, 2022 •
edited

Resolved / Related Issues
Items resolved / related issues by this PR.

Details of Changes
Add details of changes here.

  • Added the "Set as desktop slideshow" command in the ContextFlyout menu.
  • Added bigger constraints on "Set as Desktop Background" and "Set as lockscreen background" so they appear only if one image is selected.
  • Readapted CheckFileExtension in src/Files.Uwp/ViewModels/SelectedItemsPropertiesViewModel.cs to be able to handle multiples extensions in entry, reflecting any multi-selection.
  • Did some light refactor on src/Files.Uwp/ViewModels/SelectedItemsPropertiesViewModel.cs.

Validation
How did you test these changes?

  • Built and ran the app
  • Tested the changes for accessibility

Screenshots

SetAsDesktopSlideshow

@QuaintMako
Refactored two conditions to enhanced readability.
02e440b
@QuaintMako
Renamed IsItemSelected into IsAnyItemSelected to clarify its purpose.
8bd14db
@QuaintMako
'Set as desktop background' and 'Set as lockscreen background' are no…
3798601 
…w displaying if and only if one image is selected in ContextFlyoutMenu.
@QuaintMako
'Set as slideshow' action is now avalaible in the ContextFlyoutMenu w…
16b45ee 
…hen selecting multiple images.
@QuaintMako
IsSelectedItemImage now is set correctly if several images are selected.
1b311e4
@QuaintMako
'Set as Slideshow' now has the correct glyph.
cc1007b
@QuaintMako
Right clicking on selected items now correctly evaluates if only imag…
29f9c91 
…es have been selected. (files-community#5275)
@QuaintMako
Revert "Renamed IsItemSelected into IsAnyItemSelected to clarify its …
207b081 
…purpose."

This reverts commit 8bd14db. This
modification wasn't useful in the scope of the issue files-community#5275.
@QuaintMako
Added forgotten word in comment.
c8ccc4e
@yaira2
Copy link
Member

yaira2 commented Aug 14, 2022

@puppetsw does your PR also do this?

@puppetsw
Copy link
Contributor

@puppetsw does your PR also do this?

Only for the toolbar not the context menu.

@QuaintMako
FileExtensionsHelper now handles shortcuts. Now using FileExtensionsH…
a1a691e 
…elper to compare extensions in SelectedItemsPropertiesViewModel.
puppetsw
puppetsw approved these changes Aug 15, 2022
View reviewed changes
Copy link
Contributor

@puppetsw puppetsw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

yaira2
yaira2 approved these changes Aug 16, 2022
View reviewed changes
Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 merged commit 067bade into files-community:main Aug 16, 2022
@yaira2 yaira2 mentioned this pull request Aug 16, 2022
Closed
@QuaintMako QuaintMako deleted the 5275_SetMultipleImagesAsDesktopBackground branch August 16, 2022 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yaira2 yaira2 yaira2 approved these changes

@puppetsw puppetsw puppetsw approved these changes

Assignees
No one assigned
Labels
approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"Set as" Doesn't appear when selecting >1 image.
3 participants
@QuaintMako @yaira2 @puppetsw