Fixed missing icon for network folder #9752
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Actually, I guess this functionality also needs to be added for the additional network shares. I don't see an icon being added to them, but also I don't have shares to test them. Should I do it as well? |
This reverts commit d023648.
|
Hi @DavidPerikala, the icon for the sidebar items is loaded in SidebarViewModel/AddElementToSection() which ends up calling LoadDriveIcon(). The problem here was that LoadDriveIcon() was loading a file icon instead of a folder icon as default for drives. 8174c7f should be enough to fix this issue.
|
|
@gave92 Got it. Thank you. |
yaira2
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved / Related Issues
Items resolved / related issues by this PR.
Details of Changes
Validation
How did you test these changes?
Screenshots
Before:
After: