Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: Redid set as background flyout #9775

Merged
merged 10 commits into from Aug 22, 2022
Merged

Feature: Redid set as background flyout #9775

merged 10 commits into from Aug 22, 2022

Conversation

puppetsw
Copy link
Contributor

Resolved / Related Issues
Items resolved / related issues by this PR.

Details of Changes
Add details of changes here.

  • Added set as flyout to toolbar.
  • Set as desktop slideshow shows when multiple images as selected.

Validation
How did you test these changes?

  • Built and ran the app
  • Tested the changes for accessibility

Screenshots (optional)
Screenshot 2022-08-20 212506
Screenshot 2022-08-20 212449

yaira2 and others added 4 commits August 18, 2022 19:21
@yaira2
Feature: Tweaked colors on toolbar buttons
ec1b9b8
@yaira2
Added chevron to toolbar buttons with flyouts
6500eb9
@yaira2 @puppetsw
Removed x86 build from pipeline (files-community#9764)
386dd53
@puppetsw
Flyout for set as background
800b204 
Added commands to BaseLayoutCommandImplementation for slideshow.
Added resource strings
Added flyout to InnerNavigationToolbar
Hooked up commands in ShellPages
Removed unneeded code from ToolbarViewModel
@yaira2 yaira2 added the changes requested Changes are needed for this pull request label Aug 21, 2022
@yaira2 yaira2 changed the title Setas flyout Feature: Redid set as background flyout Aug 21, 2022
puppetsw and others added 4 commits August 21, 2022 14:52
@puppetsw
Revert "Removed x86 build from pipeline (files-community#9764)"
8bc050d 
This reverts commit 386dd53.
@puppetsw @yaira2
Update src/Files.Uwp/Strings/en-US/Resources.resw
9296e1b 
Co-authored-by: Yair Aichenbaum <39923744+yaichenbaum@users.noreply.github.com>
@puppetsw @yaira2
Update src/Files.Uwp/Strings/en-US/Resources.resw
8440eb6 
Co-authored-by: Yair Aichenbaum <39923744+yaichenbaum@users.noreply.github.com>
@puppetsw
Merge branch 'main' into setas_flyout
93a29c7
@puppetsw
Reverted some changes to strings. Added new strings. New button for s…
50f3183 
…lideshow displayed when multiple images selected.
@puppetsw
Copy link
Contributor Author

puppetsw commented Aug 22, 2022 •
edited

recordingexample1

I reverted some changes to the strings and added an extra for Lockscreen, as I think it makes more sense have individual ones for Lockscreen/Desktop instead of replacing SetAs_

@yaira2
Copy link
Member

yaira2 commented Aug 22, 2022

recordingexample1 recordingexample1

I reverted some changes to the strings and added an extra for Lockscreen, as I think it makes more sense have individual ones for Lockscreen/Desktop instead of replacing SetAs_

This is perfect!

yaira2
yaira2 approved these changes Aug 22, 2022
View reviewed changes
Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work! LGTM

@yaira2 yaira2 added approved and removed changes requested Changes are needed for this pull request labels Aug 22, 2022
@yaira2 yaira2 merged commit 441c122 into files-community:main Aug 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yaira2 yaira2 yaira2 approved these changes

Assignees
No one assigned
Labels
approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add set as Lockscreen button to toolbar when image files are selected
2 participants
@puppetsw @yaira2