Skip to content

Fix settings export #9797

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Aug 23, 2022
Merged

Fix settings export #9797

merged 6 commits into from
Aug 23, 2022

Conversation

gave92
Copy link
Member

@gave92 gave92 commented Aug 22, 2022 •
edited
Loading

Resolved / Related Issues
Items resolved / related issues by this PR.

Details of Changes
Add details of changes here.

  • Code for export needed to be updated for the new 7z library
  • Fix crash when viewing properties of file without extension

Validation
How did you test these changes?

  • Built and ran the app

@gave92 gave92 marked this pull request as ready for review August 22, 2022 17:06
@yaira2 yaira2 requested a review from d2dyno1 August 22, 2022 18:18
@yaira2 yaira2 added the ready for review Pull requests that are ready for review label Aug 22, 2022
d2dyno1
d2dyno1 reviewed Aug 22, 2022
View reviewed changes
d2dyno1
d2dyno1 approved these changes Aug 22, 2022
View reviewed changes
Copy link
Member

@d2dyno1 d2dyno1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also add these changes to winui3_mini later? 🙂

@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed ready for review Pull requests that are ready for review labels Aug 23, 2022
@gave92
Copy link
Member Author

gave92 commented Aug 23, 2022

Could you also add these changes to winui3_mini later? 🙂

Sure thing 👍

@yaira2 yaira2 merged commit ae93ded into files-community:main Aug 23, 2022
@gave92 gave92 deleted the issue_9789 branch August 23, 2022 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@d2dyno1 d2dyno1 d2dyno1 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Crash when opening properties of a ADS file Files carnt export settings
3 participants
@gave92 @d2dyno1 @yaira2