Skip to content

Fixed: Empty groups are still shown #9941

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Sep 15, 2022
Merged

Fixed: Empty groups are still shown #9941

merged 4 commits into from
Sep 15, 2022

Conversation

ferrariofilippo
Copy link
Contributor

Resolved / Related Issues

Details of Changes

  • Fixed: when an element is removed from a group, if the group is empty, it is deleted
  • Added null checks

Validation

  • Built and ran the app

@yaira2 yaira2 added the changes requested Changes are needed for this pull request label Sep 7, 2022
@yaira2 yaira2 changed the title Fixed: Empty groups still shown #9521 Fixed: Empty groups still shown Sep 7, 2022
yaira2
yaira2 previously approved these changes Sep 7, 2022
View reviewed changes
Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I'd like to wait for another review before merging

@yaira2 yaira2 added needs - code review and removed changes requested Changes are needed for this pull request labels Sep 7, 2022
@Josh65-2201
Copy link
Member

Does this fix #5011 also?

@ferrariofilippo
Copy link
Contributor Author

Does this fix #5011 also?

No it doesn't. Anyway I can try to work on that

@yaira2 yaira2 requested a review from d2dyno1 September 9, 2022 14:15
@yaira2
Copy link
Member

yaira2 commented Sep 9, 2022 •
edited
Loading

@ferrariofilippo btw, you can check our new project board to see which tasks have all the requirements figured out. Anything in the ready to build column has been reviewed. If something is not yet in the ready to build column and you want to work on it, mention me on the issue and I'll look it over beforehand so that there are no surprises.

@ferrariofilippo
Copy link
Contributor Author

@ferrariofilippo btw, you can check our new project board to see which tasks have all the requirements figured out. Anything in the ready to build column has been reviewed. If something is not yet in the ready to build column and you want to work on it, mention me on the issue and I'll look it over beforehand so that there are no surprises.

Ok, no problem

d2dyno1
d2dyno1 previously approved these changes Sep 15, 2022
View reviewed changes
@ferrariofilippo ferrariofilippo dismissed stale reviews from d2dyno1 and yaira2 via a8814cb September 15, 2022 15:58
yaira2
yaira2 approved these changes Sep 15, 2022
View reviewed changes
Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 changed the title Fixed: Empty groups still shown Fixed: Empty groups are still shown Sep 15, 2022
@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed needs - code review labels Sep 15, 2022
@yaira2 yaira2 merged commit 2ee36f1 into files-community:main Sep 15, 2022
@ferrariofilippo ferrariofilippo deleted the BugFix_EmptyGroups_#9521 branch September 21, 2022 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yaira2 yaira2 yaira2 approved these changes

+1 more reviewer

@d2dyno1 d2dyno1 d2dyno1 left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

When deleting only file of this day in downloads there remains tag saying Today 0 item
4 participants
@ferrariofilippo @Josh65-2201 @yaira2 @d2dyno1