Skip to content

Fix: Fixed an issue where clicking Home on the sidebar wouldn't cancel tag searches #9959

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Oct 13, 2022

Conversation

ferrariofilippo
Copy link
Contributor

Resolved / Related Issues

Details Of Changes

  • Now clicking on Home cancel tag search (lines 1094-> 1108)
  • Code Cleanup

Validation
How did you test these changes?

  • Built and ran the app

@yaira2 yaira2 changed the title Fixed: Clicking Home on sidebar doesnt cancel tag search #9877 Fixed: Clicking Home on sidebar doesnt cancel tag search Sep 9, 2022
@yaira2 yaira2 changed the title Fixed: Clicking Home on sidebar doesnt cancel tag search Fixed: Clicking Home on sidebar doesn't cancel tag search Sep 9, 2022
@yaira2 yaira2 changed the title Fixed: Clicking Home on sidebar doesn't cancel tag search Fix: Fixed an issue where clicking Home on the sidebar wouldn't cancel tag search Oct 3, 2022
@yaira2 yaira2 changed the title Fix: Fixed an issue where clicking Home on the sidebar wouldn't cancel tag search Fix: Fixed an issue where clicking Home on the sidebar wouldn't cancel tag searches Oct 3, 2022
Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ferrariofilippo
Copy link
Contributor Author

It seems that also your latest comments are still pending, I'm only able to read them only through mobile app notifications or email.

yaira2
yaira2 previously approved these changes Oct 12, 2022
Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2
Copy link
Member

yaira2 commented Oct 12, 2022

Can you resolve the merge conflicts?

@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed needs - code review labels Oct 12, 2022
@yaira2 yaira2 merged commit f1c3267 into files-community:main Oct 13, 2022
@ferrariofilippo ferrariofilippo deleted the BugFix_#9877 branch October 14, 2022 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Clicking on Home option on sidebar doesnt cancel previous tag search
2 participants