Fixed: Properties window opens behind main app window

[ferrariofilippo]

Resolved / Related Issues
Items resolved / related issues by this PR.

• Closes Bug: Properties window opens behind main app window #9926

Comments

• The root of the problem was that, after the properties windows was opened, the focus returned to the main window because of the closing of the flyout context menu. I fixed the bug opening Properties after the menu gets closed
• If everything is ok, I'll proceed with code cleanup

Validation
How did you test these changes?

• Built and ran the app

[gave92]

To be noted that there is also a simpler alternative:

// Workaround for #9926
propertiesWindow.IsAlwaysOnTop = true;
propertiesWindow.DispatcherQueue.CreateTimer().Debounce(() =>
{
    if (propertiesWindow.Visible)
    {
        propertiesWindow.Activate();
        propertiesWindow.IsAlwaysOnTop = false;
    }
}, TimeSpan.FromSeconds(1));

Adding the above in OpenPropertiesWindowAsync() (@ line 82) appears to be enough to fix the issue. It's a bit hacky though.

[ferrariofilippo]

To be noted that there is also a simpler alternative:

// Workaround for #9926
propertiesWindow.IsAlwaysOnTop = true;
propertiesWindow.DispatcherQueue.CreateTimer().Debounce(() =>
{
    propertiesWindow.Activate();
    propertiesWindow.IsAlwaysOnTop = false;
}, TimeSpan.FromSeconds(1));

Adding the above in OpenPropertiesWindowAsync() (@ line 82) appears to be enough to fix the issue. It's a bit hacky though.

I took into account a solution like this, but there are two drawbacks: if, for any reason, the flyout context menu takes more than a second to close, the bug would remain unfixed (it would be a one-in-a-million case). The second problem is that the program might seem not optimized or inefficient because of that delay. I know it's only a second, but I'm obsessed with optimization.

[gave92]

For "optimization" the simple solution is actually better since you don't wait for the menu to close before opening the properties window. But I agree it might not cover all cases.
Edit: also it has an issue where keyboard navigation in properties window starts working after 1 second.

[yaira2]

Using the hwnd, can we force the new window to the foreground?

[gave92]

With my solution I set it always on top for 1 second. It appears in front but it's not active. Not sure if we can force it to be active.

[ferrariofilippo]

Using the hwnd, can we force the new window to the foreground?

You can't really do that the way we'd want to.
Setting IsAlwaysOnTop to true means that the Properties Window can't be hidden by any other window (I don't think we want this).
Forcing the Prop. Window to be shown above others (using BringToFront() or MoveInZOrderToTop()) would be useless, because, as the context menu closes, the main window will be brought on top of others.
Mine and @gave92 solutions are the only viable.

[yaira2]

LGTM

[yaira2]

@ferrariofilippo does this work for the drives widget as well?

[ferrariofilippo]

@ferrariofilippo does this work for the drives widget as well?

Yes, it does

[gave92]

@ferrariofilippo solution looks good to me. I just find it annoying that it has to be done in each place we have a context menu and each has slightly different code, but no biggie.

[yaira2]

Likewise but this is still a good solution