Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(picker): Add onFileCropped callback #264

Merged
merged 1 commit into from
Jul 25, 2019
Merged

Conversation

pcholuj
Copy link
Contributor

@pcholuj pcholuj commented Jul 23, 2019

Picker

  • Add onFileCropped callback
  • Fix Italian translation in picker

Sdk

  • Set apikey as tag in sentry
  • Update some error messages

@codecov
Copy link

codecov bot commented Jul 23, 2019

Codecov Report

Merging #264 into master will not change coverage.
The diff coverage is 75%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #264   +/-   ##
======================================
  Coverage    99.1%   99.1%           
======================================
  Files          32      32           
  Lines        1452    1452           
  Branches      210     210           
======================================
  Hits         1439    1439           
  Misses         13      13
Impacted Files Coverage Δ
src/lib/client.ts 100% <ø> (ø) ⬆️
src/lib/picker.ts 100% <ø> (ø) ⬆️
src/config.ts 100% <100%> (ø) ⬆️
src/lib/api/upload/uploaders/s3.ts 98.72% <66.66%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 71f38b1...8f5f19d. Read the comment docs.

@pcholuj pcholuj merged commit a598ea6 into master Jul 25, 2019
@pcholuj pcholuj deleted the feature/cropCallback branch July 25, 2019 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants