Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

processing ng docs site results in FormatException: Expecting '=' #1

Closed
chalin opened this issue Nov 20, 2016 · 8 comments
Closed

processing ng docs site results in FormatException: Expecting '=' #1

chalin opened this issue Nov 20, 2016 · 8 comments
Assignees

Comments

@chalin
Copy link
Collaborator

chalin commented Nov 20, 2016

Running linkcheck over the ng docs dev site:

linkcheck https://angulardart-org-dev.firebaseapp.com

results in

.../static-assets/styles.css
Unhandled exception:
FormatException: Expecting '=' (at character 24)
data:image/svg+xml;utf8,<svg xmlns='http://www.w3.org/2000/svg' width='16' ...
                       ^

Context: we're using the dartdoc generated pages for https://github.com/dart-lang/angular2 via https://github.com/dart-lang/site-webdev. Running linkcheck over the resulting webdev site resulted in the error above.

cc @kwalrath @ericjim

@filiph
Copy link
Owner

filiph commented Nov 22, 2016

I cannot reproduce so far. Which version of linkcheck are you using (linkcheck -v)? Can you link to a file that does this (like the styles.css one mentioned in the report)?

@filiph filiph self-assigned this Nov 22, 2016
@chalin
Copy link
Collaborator Author

chalin commented Nov 22, 2016

linkcheck -v

linkcheck version 0.2.9

Have you tried running it on the dev site?
linkcheck https://angulardart-org-dev.firebaseapp.com

@chalin
Copy link
Collaborator Author

chalin commented Nov 22, 2016

I just ran the linkcheck over the dev site and it reports the error given in the original comment of this issue. Do you get the same error? I can give you a full stack trace if that will help.

@filiph
Copy link
Owner

filiph commented Dec 2, 2016

Sorry for dropping the ball on this. For the record, I couldn't replicate and my test case works. I'll look at it once more.

@filiph
Copy link
Owner

filiph commented Dec 2, 2016

Alright, I might have forgot to actually publish (even before this issue was reported, so my local copy was fine while the external had this issue).

Please pub global activate linkcheck to upgrade to version 0.2.11 or above. This should resolve the issue.

@filiph filiph closed this as completed Dec 2, 2016
@filiph
Copy link
Owner

filiph commented Dec 2, 2016

Ok, I reproduced. Still no reproducible test case, but at least I was able to see the issue myself.

@filiph filiph reopened this Dec 2, 2016
@filiph filiph closed this as completed in ff451a8 Dec 2, 2016
@filiph
Copy link
Owner

filiph commented Dec 2, 2016

Ok, this is hopefully fixed with ff451a8. Please update to 0.2.13 by running pub global activate linkcheck.

Sorry that this took so long. (In the end, it was a one-char change, essentially. Welp.)

@chalin
Copy link
Collaborator Author

chalin commented Dec 5, 2016

Yes, fixed, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants