-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Payments #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabrielecanepa
added
the
changes requested
Don't merge yet, some changes are needed
label
Apr 27, 2020
set up a transfer if the user already has a stripe account (this will be easier, since you won't have to enter your info)This comment was generated by todo based on a
|
Check to see what happens if user doesn't have an avatarThis comment was generated by todo based on a
|
Once we implement a chat feature we should redirect there instead of directly to the paymentThis comment was generated by todo based on a
|
add more rulesThis comment was generated by todo based on a
|
Style the "Choose File" button %>This comment was generated by todo based on a
|
We might also want to have this somewhere in the dashboard %>This comment was generated by todo based on a
|
This is just a basic view, feel free to completely change it %>This comment was generated by todo based on a
|
add secure state %>This comment was generated by todo based on a
|
add more stripe_user[] fields to url, to fill out location https://stripe.com/docs/connect/oauth-reference#prefill-fields %>This comment was generated by todo based on a
|
This bid input needs to be deisgned better, and I was also having some issues with the bid appearing as 0 when it was not supposed to be %>This comment was generated by todo based on a
|
Add notifications to let the other party know when a transation goes throughThis comment was generated by todo based on a
|
set up a transfer if the user already has a stripe account (this will be easier, since you won't have to enter your info)This comment was generated by todo based on a
|
Check to see what happens if user doesn't have an avatarThis comment was generated by todo based on a
|
can this be secured further?This comment was generated by todo based on a
|
Style the "Choose File" button %>This comment was generated by todo based on a
|
We might also want to have this somewhere in the dashboard %>This comment was generated by todo based on a
|
This is just a basic view, feel free to completely change it %>This comment was generated by todo based on a
|
add more stripe_user[] fields to url, to fill out location https://stripe.com/docs/connect/oauth-reference#prefill-fields %>This comment was generated by todo based on a
|
This bid input needs to be deisgned better, and I was also having some issues with the bid appearing as 0 when it was not supposed to be %>This comment was generated by todo based on a
|
We might also want to have this somewhere in the dashboard %>This comment was generated by todo based on a
|
This is just a basic view, feel free to completely change it %>This comment was generated by todo based on a
|
add more stripe_user[] fields to url, to fill out location https://stripe.com/docs/connect/oauth-reference#prefill-fields %>This comment was generated by todo based on a
|
This bid input needs to be deisgned better, and I was also having some issues with the bid appearing as 0 when it was not supposed to be %>This comment was generated by todo based on a
|
set up a transfer if the user already has a stripe account (this will be easier, since you won't have to enter your info)This comment was generated by todo based on a
|
Check to see what happens if user doesn't have an avatarThis comment was generated by todo based on a
|
Style the "Choose File" button %>This comment was generated by todo based on a
|
We might also want to have this somewhere in the dashboard %>This comment was generated by todo based on a
|
This is just a basic view, feel free to completely change it %>This comment was generated by todo based on a
|
add more stripe_user[] fields to url, to fill out location https://stripe.com/docs/connect/oauth-reference#prefill-fields %>This comment was generated by todo based on a
|
This bid input needs to be deisgned better, and I was also having some issues with the bid appearing as 0 when it was not supposed to be %>This comment was generated by todo based on a
|
set up a transfer if the user already has a stripe account (this will be easier, since you won't have to enter your info)This comment was generated by todo based on a
|
Style the "Choose File" button %>This comment was generated by todo based on a
|
We might also want to have this somewhere in the dashboard %>This comment was generated by todo based on a
|
This is just a basic view, feel free to completely change it %>This comment was generated by todo based on a
|
add more stripe_user[] fields to url, to fill out location https://stripe.com/docs/connect/oauth-reference#prefill-fields %>This comment was generated by todo based on a
|
This bid input needs to be deisgned better, and I was also having some issues with the bid appearing as 0 when it was not supposed to be %>This comment was generated by todo based on a
|
This was referenced Apr 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
I have implemented a payment system using stripe. Users can now bid and accept payments for tasks.
Configuration
You must run bundle, migrate the db, as well as seed. You also have to set up all the Stripe environment variables, check the README.
Details
A user can:
I still need to test a bit more, as well as adding more pundit rules, and there is a parameter "state" that I pass to the stripe api, and right now it is not secure.
I will open this as a draft for now, but it is pretty much done. I also added a bunch of TODO's for stuff I think needs done 😉👌
Screenshots