Skip to content

FINDO-8584_color_filter_schema_and_reality_must_match #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 28, 2020
Merged

FINDO-8584_color_filter_schema_and_reality_must_match #11

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e7af80d
Rename colorCode to color for color filters
howard Apr 28, 2020
c160a70
Make requestId and userId optional
howard Apr 28, 2020
f37c3b7
Make product placement name nullable
howard Apr 28, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion example/response.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,7 @@
"values": [
{
"value": "Green",
"colorCode": "#00FF00"
"color": "#00FF00"
}
]
}
Expand Down
6 changes: 2 additions & 4 deletions resources/schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@
],
"description": "In case of a selected-filter, this property indicates whether the frequency is the number of additional products you'll get after selecting the filter (additive), or whether it's the total number of results you'll have after selecting the filter (absolute)."
},
"colorCode": {
"color": {
"description": "For color filters, the hexadecimal code corresponding to the color. The filter's value is the configured color name in such a case.",
"type": "string",
"pattern": "^#[0-9A-Fa-f]{6}$"
Expand Down Expand Up @@ -259,7 +259,6 @@
"count",
"serviceId",
"usergroup",
"userId",
"order"
]
},
Expand Down Expand Up @@ -342,7 +341,6 @@
"landingpage",
"promotion",
"searchConcept",
"requestId",
"effectiveQuery",
"totalResults",
"currencySymbol"
Expand Down Expand Up @@ -445,7 +443,7 @@
}
},
"productPlacement": {
"type": "string",
"type": ["string", "null"],
"minLength": 1,
"description": "In case a Product Placement matches the product, this is its name."
},
Expand Down