FINDO-8454_combine_available_and_selected_filters (Step 2: Add the story points) #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wladi0097
changed the title
wladi0097
changed the base branch from
0.x
to
FINDO-8454_2nd_combine_available_and_selected_filters
…into FINDO-8454_combine_available_and_selected_filters
howard
requested changes
Feb 19, 2020
resources/schema.json
Outdated
| "multiple" | ||
| ], | ||
| "description": "Whether one or more filter values can be selected at the same time. Only applies to a subset of available filter types." | ||
| "description": "Whether one or more filter values can be selected at the same time. Only applies to a subset of available filter types. Filters of select-type single have just one value to select, unless 'cat'-filter and range-filter. Filters of select-type multiple with 'combinationOperation' of type 'or' can have more than one value, each values are OR-combined. Filters of select-type multiple with 'combinationOperation' of type 'and' can have more than one value, each values are AND-combined." |
There was a problem hiding this comment.
Filters of select-type single have just one value to select, unless 'cat'-filter and range-filter.
cat and range filters are literally the only ones with select type single, right? This sentence sounds contradictory.
Filters of select-type multiple with 'combinationOperation' of type 'and' can have more than one value, each values are AND-combined."
...each value is AND-combined.
There was a problem hiding this comment.
This whole thing just has way to many redundant informations. The best explanation would be Whether one or more filter values can be selected at the same time. I think
added 2 commits
February 19, 2020 17:07
…into FINDO-8454_combine_available_and_selected_filters
howard
approved these changes
Feb 20, 2020
howard
merged commit 1619b0b
into
FINDO-8454_2nd_combine_available_and_selected_filters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.