-
Notifications
You must be signed in to change notification settings - Fork 146
Description
Date
20251006 - 4pm BST / 11am EDT
Meeting info
Untracked attendees
- Full Name, Affiliation, (optional) GitHub username
- ...
Meeting notices
-
FINOS Project leads are responsible for observing the FINOS guidelines for running project meetings. Project maintainers can find additional resources in the FINOS Maintainers Cheatsheet.
-
All participants in FINOS project meetings are subject to the LF Antitrust Policy, the FINOS Community Code of Conduct and all other FINOS policies.
-
FINOS meetings involve participation by industry competitors, and it is the intention of FINOS and the Linux Foundation to conduct all of its activities in accordance with applicable antitrust and competition laws. It is therefore extremely important that attendees adhere to meeting agendas, and be aware of, and not participate in, any activities that are prohibited under applicable US state, federal or foreign antitrust and competition laws. Please contact legal@finos.org with any questions.
-
FINOS project meetings may be recorded for use solely by the FINOS team for administration purposes. In very limited instances, and with explicit approval, recordings may be made more widely available.
Agenda
- Convene & roll call (5mins)
- Review Meeting Notices (see above)
- Approve past meeting minutes
- TS Refactor PRs review + merge
- PluginLoader ESM issues (found during Vitest conversion)
- Vitest does not support CommonJS plugin loading, perhaps a
load-plugin
library issue?
- Vitest does not support CommonJS plugin loading, perhaps a
- New issues raised since last meeting
- feat: e2e tests using docker compose #1165 & feat(db): add MongoDB integration tests & CI support #1200
- feat(db): add MongoDB integration tests & CI support #1200 was not discussed due to lack of time
- AOB, Q&A & Adjourn (5mins)
Meeting Minutes
-
Approval of Past Meeting Minutes
- Minutes from the 22nd September 2025 (22nd September 2025 - GitProxy Meeting Minutes #1194) were reviewed and approved without objection.
- @06kellyjac confirmed work started on supporting alternative emails for committers; action assigned to them.
- Discussion on Dockerised testing and test coverage; consensus that the Docker Compose-based e2e testing approach is sound and should progress.
-
TS Refactor PRs Review and Merge
- Several TypeScript (TS) refactor PRs are ready or nearly ready for merge.
- @jescalada is finalising PRs but the CLI PR is pending review from @kriswest.
- Service PR needs a last round of review; coverage drop to be checked by @jescalada.
- Build scripts and folder structure discussed; plan to move away from legacy workflows towards typical TS 'dist' patterns.
- @fabiovincenzi will take on the action of adjusting build scripts and related changes based on guidance from @06kellyjac and @kriswest.
-
PluginLoader ESM Issues (Vitest Conversion)
- @jescalada flagged ongoing issues with PluginLoader tests during ESM/Vitest migration.
- @coopernetes advised removing/dropping the legacy plugin system for now and revisiting design for v2.0.
- Group confirmed no objections to removing the current plugin loader and tests; @jescalada to proceed.
-
New Issues Raised Since Last Meeting
- @kriswest outlined new issues filed, including:
- Removal of base URL from config schemas (@andypols, @kriswest to coordinate).
- Completion of missing config schema fields and types—@kriswest to submit PR shortly, will tag @06kellyjac for review.
- Literal string handling in diff scanning is currently broken—needs regex escaping; anyone able to assist is encouraged to do so.
- Some JS files remain in UI code; @jescalada will submit a PR after finishing Vitest migration.
- Performance-related conversation on improving pull times, including caching approaches and shallow checkouts. Caution advised regarding Git credentials.
- @kriswest outlined new issues filed, including:
-
feat: e2e tests using docker compose feat: e2e tests using docker compose #1165 & feat(db): add MongoDB integration tests & CI support feat(db): add MongoDB integration tests & CI support #1200
- End-to-end tests using Docker Compose were discussed. @coopernetes' PR is generally agreed to be a good approach, with some review comments pending.
- MongoDB integration tests & CI support (feat(db): add MongoDB integration tests & CI support #1200) was not discussed due to time constraints and is deferred to the next meeting.
-
Other Business (AOB)
- @dcoric provided an update on the SSH feature, which should be ready for testing soon.
- Discussion on high watermark for streams and pull performance; @fabiovincenzi is experimenting with caching and performance improvements but will be mindful of credential management.
- Further exploration needed for optimal checkout strategies, especially for large repositories; shallow checkout strategies to be tested.
- Agreement to continue action-oriented approach to meetings and encourage agenda contributions.
Action Items
Rolled over from the previous meeting:
- @06kellyjac and @kriswest to consider design/implementation for a general notification system.
- @sam-holmes2 to update and resolve conflicts in the Apache 2 license headers PR and consider integrating ESLint plugin for automation.
- @jescalada to complete refactoring tests to Vitest + TS
New actions:
- @06kellyjac to continue work on alternative email support and update when ready for review.
- @jescalada to finalise TS Service PR (resolve conflicts, check coverage) and ping for final review.
- @kriswest to review and unblock CLI PR for TS refactor.
- @fabiovincenzi to update build/publish scripts as per new TS dist folder conventions, removing legacy scripts and adjusting SED logic as discussed.
- @06kellyjac to review build script/package.json changes once @fabiovincenzi has a PR up.
- @jescalada to remove legacy plugin loader and tests, and document approach for v2.0 extensibility.
- @kriswest to submit PR for missing config schema fields/types and tag @06kellyjac for review, particularly regarding providers/patterns logic.
- @kriswest (or anyone available) to fix literal string handling in diff scanning (ensure regex escaping).
- @jescalada to submit PR converting remaining UI JavaScript files to TypeScript after Vitest migration.
- @andypols/@kriswest to remove base URL property from config schema as appropriate.
- @coopernetes to complete review comments and update e2e Docker Compose PR (feat: e2e tests using docker compose #1165).
- @kriswest to raise an issue for build provenance.
- @sam-holmes2 to follow up (with @coopernetes) on Apache 2 license header automation via ESLint.
- @fabiovincenzi to continue performance experiments on repo caching, with attention to credential safety.
- @coopernetes/@fabiovincenzi/@kriswest to test shallow checkout approaches and confirm diff correctness.
- @kriswest to set agenda for next meeting and encourage topic suggestions.
- MongoDB integration tests & CI support feat(db): add MongoDB integration tests & CI support #1200: Carry forward to next meeting for discussion.