-
Notifications
You must be signed in to change notification settings - Fork 146
fix: allowing empty diffs in scanDiff #1182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for endearing-brigadeiros-63f9d0 canceled.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1182 +/- ##
==========================================
+ Coverage 83.67% 83.71% +0.03%
==========================================
Files 67 67
Lines 2886 2886
Branches 365 365
==========================================
+ Hits 2415 2416 +1
Misses 410 410
+ Partials 61 60 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Little confused about the test expecting two different possible outputs (block and non-block).
Test files could be moved into the /test/processors folder.
…-proxy into pr/fabiovincenzi/1182
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Fixes #1008 - scanDiff now properly handles force pushes after rebases by allowing legitimate empty diffs instead of blocking them.