Skip to content

Conversation

fabiovincenzi
Copy link
Contributor

Fixes #1008 - scanDiff now properly handles force pushes after rebases by allowing legitimate empty diffs instead of blocking them.

@github-actions github-actions bot added the fix label Sep 1, 2025
Copy link

netlify bot commented Sep 1, 2025

Deploy Preview for endearing-brigadeiros-63f9d0 canceled.

Name Link
🔨 Latest commit 35e88fa
🔍 Latest deploy log https://app.netlify.com/projects/endearing-brigadeiros-63f9d0/deploys/68c143c863675900080f3250

Copy link

codecov bot commented Sep 3, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.71%. Comparing base (c530aac) to head (35e88fa).
⚠️ Report is 15 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1182      +/-   ##
==========================================
+ Coverage   83.67%   83.71%   +0.03%     
==========================================
  Files          67       67              
  Lines        2886     2886              
  Branches      365      365              
==========================================
+ Hits         2415     2416       +1     
  Misses        410      410              
+ Partials       61       60       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@kriswest kriswest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Little confused about the test expecting two different possible outputs (block and non-block).

Test files could be moved into the /test/processors folder.

Copy link
Contributor

@kriswest kriswest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kriswest kriswest merged commit 93a1aaf into finos:main Sep 10, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(bug) scanDiff fails on force pushes
2 participants