fix: bug in using API_BASE with URL

[andypols]

Summary

This PR fixes a bug introduced in #1201 related to the URL API.

The URL constructor does not support relative paths. When process.env.VITE_API_URI is not defined, API_BASE falls back to a relative path. As a result, code like this throws an exception in certain environments:

const url = new URL(`${API_BASE}/api/auth/gitAccount`);

Fix

• Remove the use of URL objects when building url string with ${API_BASE}.
  • URLs are now built as plain strings.
• Cleaned up unused query param handling:
  • /api/v1/user does not pass any query params.
  • getUsers always passed an empty query params object.
  • No params are ever passed into UserList

[netlify]

✅ Deploy Preview for endearing-brigadeiros-63f9d0 canceled.

Name	Link
🔨 Latest commit	c6e3635
🔍 Latest deploy log	https://app.netlify.com/projects/endearing-brigadeiros-63f9d0/deploys/68d6d88bbf3547000834ba72

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.20%. Comparing base (db1debc) to head (c6e3635).
⚠️ Report is 8 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1228      +/-   ##
==========================================
+ Coverage   84.01%   84.20%   +0.18%     
==========================================
  Files          68       68              
  Lines        2947     2938       -9     
  Branches      374      374              
==========================================
- Hits         2476     2474       -2     
+ Misses        411      404       -7     
  Partials       60       60              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[kriswest]

I'm ok with dropping the unused query args (which may need to come back one day for server-side pagination or filtering). However, I think API_BASE needs to fall back to location.origin.

I'll raise an issue for the remaining UI services to be converted to TS - they should also use API_BASE (instead of each working it out themselves), but will need the location.origin fallback (I guess).

[andypols]

@kriswest Ok - I'm fine with defaulting to location.origin. The original bug I was fixing is that logout defaulted to http://localhost:3000. Not sure if you are saying this PR should do that or the one you are raising for the remaining services?

[kriswest]

The other services currently default to location.origin - I didn't notice user.ts had lost that in the original PR (but was happy to see the hardcoded http://localhost:3000 fallback go). I think the location.origin fallback needs reinstating here (and can then be used when converting the other services), with the test adjusted to confirm it.

[kriswest]

LGTM