Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

X/Y Scatter Symbol Serialization as Dictionary #2429

Merged
merged 2 commits into from
Nov 17, 2023

Conversation

ada-x64
Copy link
Contributor

@ada-x64 ada-x64 commented Nov 13, 2023

This PR changes the X/Y Scatter plot's symbol serialization format to a dictionary. It also fixes a bug in the datagrid. (Editable bools were not toggling correctly.)

@ada-x64 ada-x64 force-pushed the bugs/xy-scatter-serialization-rebase branch from 6602352 to bde7d21 Compare November 17, 2023 15:08
Copy link
Member

@texodus texodus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Looks good!

@texodus texodus added bug Concrete, reproducible bugs breaking labels Nov 17, 2023
@texodus texodus merged commit 59dc3a2 into finos:master Nov 17, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking bug Concrete, reproducible bugs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants