feat: implement React wrappers for FDS components #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Create a workaround for keeping generic value type of Dropdown component when creating a React wrapper. Note: this React component is unusable until this bug is fixed in the web component repository fintraffic-design/fds-coreui-components#65 but this change has been tested with a locally patched version of the web component.
|
These components have been tested to work in a React test app, except FdsDropdown does not yet work due to a bug in the web component. It will start working after this is fixed fintraffic-design/fds-coreui-components#65 |
|
One notable DX challenge we still have with this is how to make render props (currently |
ninopenttinen
approved these changes
Feb 2, 2024
Haprog
force-pushed
the
feat/initial-setup
branch
from
177000c to
8643363
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial implementation of React wrappers for FDS components.
Closes fintraffic-design/fds-coreui-components#56