READY FOR REVIEW - Fix #169. Set correct Content-Type for JSON-RPC responses. #170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
UPDATE: Failed tests are unrelated to this PR. See this comment and #164. Original comment preserved below. Hmmm...I haven't modified any of the tests, and I don't think the failing one ( |
Closed
vltr
pushed a commit
to vltr/cyclone
that referenced
this pull request
Oct 16, 2015
…t for default jsonrpc headers for fiorix#170
…ve text/html Content-Type for errors.
fiorix
added a commit
that referenced
this pull request
Jan 7, 2016
…-type READY FOR REVIEW - Fix #169. Set correct Content-Type for JSON-RPC responses.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #169. Set correct
Content-Typefor JSON-RPC responses.I don't see an existing test harness for
JsonrpcRequestHandlerorRequestHandler, otherwise I would have included unit tests. However, it does appear to work when I test it by hand (both with normal and error responses):