Skip to content

FirestorePagingAdapter does not log errors by default #1652

@sanisloandras

Description

@sanisloandras

Hello!

Recently I discovered that FirestorePagingAdapter does not log errors by default, while FirestoreRecylcerAdapter does.
I think it should save developers some time. I lost some time while debugging why my FirestorePagingAdapter didn't not display any data. I simply forgot to create an index, but I didn't get the warning log about that, because FirestorePagingAdapter's onError method body is empty.

FirestoreRecyclerAdapter:
@Override public void onError(@NonNull FirebaseFirestoreException e) { Log.w(TAG, "onError", e); }

FirestorePagingAdapter:
protected void onError(@NonNull Exception e) { // For overriding }

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions