Skip to content

Fix oversight introduced in #1010 #1019

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 17, 2017
Merged

Fix oversight introduced in #1010 #1019

merged 1 commit into from
Nov 17, 2017

Conversation

SUPERCILEX
Copy link
Collaborator

@samtstern Oops! 😊

The code should explain what I mean and prevent future devs from making the same mistake.

@SUPERCILEX SUPERCILEX changed the title Fix oversight introduced in 7ca3cbf112854b63f6a980e0b2aef8294a67e67c Fix oversight introduced in #1010 Nov 17, 2017
@samtstern
Copy link
Contributor

Oops I should have caught this, thanks!

@samtstern samtstern merged commit 93c3419 into firebase:version-3.1.1-dev Nov 17, 2017
@SUPERCILEX SUPERCILEX deleted the patch-1 branch November 17, 2017 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants