Fix landscape NASCAR layout

[samtstern]

See #1434

I also updated the sample app in two ways:

• Combine the ToS and PP selection radio box now that we make you pass them together anyway
• Allow a 'None' option

Here's how it looks now:

[SUPERCILEX]

I wanted to do that too, but then this happens. Maybe you know more ConstraintLayout jitsu? 😆

[samtstern]

Hmmm. I probably need to mess with the vertical chain type then. All the "padding" on the ToS/PP text isn't actually padding, it's a result of the view bounds stretching to meet its constraints.

[samtstern]

@SUPERCILEX I think at some point with split screen there's no good layout. Here's what I have now at half-screen in both portrait and landscape. IMO it looks as good as we can hope for.

Plus while it's a bummer visually, I think if you have a terms/privacy policy you need them to be visible at all costs.

Half of Lanscape

Half of Portrait

[SUPERCILEX]

A few thoughts:

• Is the large layout-land fixed? Since you reverted wrap_content and didn't add the contraint weights, I'm pretty sure this doesn't fix the original issue 😂
• The ToS actually scrolls so I don't think it's too big a deal if not all of it is visible at once
• Small layouts are hard! 🤪

[samtstern]

What do you mean by "large layout-land"? I think that's what I showed in the very first comment, but maybe there's something else?

Also how does the ToS scroll?

[SUPERCILEX]

The first comment used wrap_content, right? But in the last commit, you changed it back to 0dp so the logo doesn't disappear on small screens... which means we're back to square 1.

When you're in vertical split screen mode, you can move the slider up to squish our poor app even further into oblivion. Then the ToS will be cut off but scrollable.

[samtstern]

Yep the landscape (the original bug) is still working with the latest commits:

[SUPERCILEX]

Ohhh, nevermind you made the ScrollView 0dp. So that means the screenshot below is still a bug on your branch. Were you saying that's ok? That's why I was pointing out that the ToS is scrollable.

I've created a patch with my fix to clear confusion, but it does mean you have to scroll the ToS. WDYT? Is that a reasonable tradeoff?

[samtstern]

@SUPERCILEX thanks for the patch! I applied it and it definitely helps in the super-small situation.

From what I can tell, this now looks passable in any configuration of options/orientation/size.

[SUPERCILEX]

👏