Stabilize Build #1463
Merged
Stabilize Build #1463
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-Id: I2a1466059e8515d0fa6d4e5d957321ac086883d7
SUPERCILEX
reviewed
Sep 26, 2018
| @@ -1,3 +1,6 @@ | |||
| // This is always set to 'true' on Travis CI | |||
| val inCiBuild = System.getenv("CI") == "true" | |||
There was a problem hiding this comment.
I would check for nullity instead so we're resilient to possible changes: https://github.com/SUPERCILEX/Robot-Scouter/blob/2da4e7eed01da413eb151ce8cb09c75e33e7d53d/buildSrc/src/main/kotlin/com/supercilex/robotscouter/build/internal/Constants.kt#L8
|
Oooooh, just a second too late 😂. Shouldn't really matter so 🤷♂️👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #1462
These are some very simple changes but on my machine they have an impact on stability 🤷♂️