Skip to content

Polish custom layout implementation #1513

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Nov 4, 2018
Merged

Polish custom layout implementation #1513

merged 7 commits into from
Nov 4, 2018

Conversation

samtstern
Copy link
Contributor

@samtstern samtstern commented Oct 31, 2018 •
edited
Loading

Some final items for #1477

TODO:

  • Make a nice custom layout for the sample app
  • Make the custom layout chosen with a radio button in the sample app
  • Obvious failure for provider configuration mismatch
  • README
  • JavaDoc
  • ToS and PP in custom layout

Here's a preview:
device-2018-10-31-113747

@samtstern samtstern added this to the 4.3.0 milestone Oct 31, 2018
@samtstern samtstern changed the title [WIP] Polish custom layout implementation Polish custom layout implementation Oct 31, 2018
@samtstern samtstern requested a review from lsirac October 31, 2018 11:05
@samtstern
Copy link
Contributor Author

cc @iamyaoxi

@yos1p
Copy link
Contributor

yos1p commented Oct 31, 2018

The layout is very sweet!!

lsirac
lsirac reviewed Nov 1, 2018
View reviewed changes
Copy link
Contributor

@lsirac lsirac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have much to add - it looks like it doesn't work in landscape though:

screenshot_20181101-103351

auth/src/main/java/com/firebase/ui/auth/ui/idp/AuthMethodPickerActivity.java
logo.setImageResource(logoId);
}
}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: extra spaces

app/src/main/res/drawable/custom_bg_gradient.xml Outdated
android:startColor="#7986cb"
android:endColor="#7e57c2"
android:angle="270"/>
</shape> No newline at end of file
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: no new line

@samtstern
Copy link
Contributor Author

@lsirac good catch on landscape!

@samtstern samtstern merged commit e3d32ac into version-4.3.0-dev Nov 4, 2018
@samtstern samtstern mentioned this pull request Nov 19, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@lsirac lsirac lsirac left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

4.3.0

Development

Successfully merging this pull request may close these issues.

3 participants

@samtstern @yos1p @lsirac