Skip to content

Change provider priorities #1530

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 9, 2018
Merged

Change provider priorities #1530

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 18 additions & 3 deletions auth/src/main/java/com/firebase/ui/auth/util/data/ProviderUtils.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -221,14 +221,29 @@ public Task<List<String>> then(@NonNull Task<SignInMethodQueryResult> task) {
}
// Reorder providers from most to least usable. Usability is determined by
// how many steps a user needs to perform to log in.
maximizePriority(lastSignedInProviders, GoogleAuthProvider.PROVIDER_ID);
reorderPriorities(lastSignedInProviders);

return Tasks.forResult(lastSignedInProviders);
}

private void maximizePriority(List<String> providers, String id) {
private void reorderPriorities(List<String> providers) {
// Prioritize Google over everything else
// Prioritize email-password sign in second
// De-prioritize email link sign in
changePriority(providers, EmailAuthProvider.PROVIDER_ID, true);
changePriority(providers, GoogleAuthProvider.PROVIDER_ID, true);
changePriority(providers, EMAIL_LINK_PROVIDER, false);
}

private void changePriority(List<String> providers,
String id,
boolean maximizePriority) {
if (providers.remove(id)) {
providers.add(0, id);
if (maximizePriority) {
providers.add(0, id);
} else {
providers.add(id);
}
}
}
});
Expand Down