Method to update Query in Firebase and Firestore Adapters. by PatilShreyas · Pull Request #1660 · firebase/FirebaseUI-Android

PatilShreyas · 2019-07-20T14:27:05Z

This PR Implements a method to change/update Query in both Firebase as well as Firestore Adapters. (Issue #1614)

…ter` firebase#1614

…aseUI-Android into sp-feature-1614

…-1614

PatilShreyas · 2019-07-20T14:41:25Z

@samtstern There are some Auth lint errors exists that's why Trivis CI failed.

PatilShreyas · 2019-07-22T16:25:38Z

@samtstern These are errors.

  The first 3 errors (out of 84) were:
  /home/travis/build/firebase/FirebaseUI-Android/auth/src/main/res/layout/fui_auth_method_picker_layout.xml:11: Error: This view is not constrained horizontally: at runtime it will jump to the left unless you add a horizontal constraint [MissingConstraints]
      <me.zhanghai.android.materialprogressbar.MaterialProgressBar
       ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  /home/travis/build/firebase/FirebaseUI-Android/auth/src/main/res/layout-land/fui_auth_method_picker_layout.xml:12: Error: This view is not constrained horizontally: at runtime it will jump to the left unless you add a horizontal constraint [MissingConstraints]
      <me.zhanghai.android.materialprogressbar.MaterialProgressBar
       ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  /home/travis/build/firebase/FirebaseUI-Android/auth/src/main/res/layout/fui_confirmation_code_layout.xml:9: Error: This view is not constrained. It only has designtime positions, so it will jump to (0,0) at runtime unless you add the constraints [MissingConstraints]
      <me.zhanghai.android.materialprogressbar.MaterialProgressBar
       ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

  The first 3 errors (out of 4) were:
  /home/travis/build/firebase/FirebaseUI-Android/app/src/main/res/layout/auth_method_picker_custom_layout.xml:81: Error: This namespace declaration is redundant [RedundantNamespace]
      <com.firebase.ui.auth.util.ui.SupportVectorDrawablesButton xmlns:android="http://schemas.android.com/apk/res/android"
                                                                 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  /home/travis/build/firebase/FirebaseUI-Android/app/src/main/res/layout-land/auth_method_picker_custom_layout.xml:98: Error: This namespace declaration is redundant [RedundantNamespace]
      <com.firebase.ui.auth.util.ui.SupportVectorDrawablesButton xmlns:android="http://schemas.android.com/apk/res/android"
                                                                 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  /home/travis/build/firebase/FirebaseUI-Android/app/src/main/res/values/strings.xml:26: Error: Duplicate string value Google, used in logo_google, providers_google and tos_pp_google [DuplicateStrings]
      <string name="providers_google">Google</string>
      ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      /home/travis/build/firebase/FirebaseUI-Android/app/src/main/res/values/strings.xml:46: Duplicates value in providers_google
      /home/travis/build/firebase/FirebaseUI-Android/app/src/main/res/values/strings.xml:50: Duplicates value in providers_google

samtstern

@PatilShreyas thanks for this! Just a few comments.

samtstern · 2019-07-23T16:29:22Z

+     *
+     * @param newQuery is a new updated query.
+     */
+    public abstract void updateQuery(@NonNull Query newQuery);


Should this be added in BaseObservableSnapshotArray instead? It seems a bit strange that this would be the only method defined on ObservableSnapshotArray

Because BaseObservableSnapshotArray is inherited in both ObservableSnapshotArray of Firestore as well as Firebase realtime database too. And most importantly, the Query class of both databases are not the same.

Firestore Query Class: com.google.firebase.firestore.Query

Firebase Query Class: com.google.firebase.database.Query

If we add this method in BaseObservableSnapshotArray then Query parameter will be different for them. What else can we do here?

I would say let's just not make this part of the base class at all, it can just be something implemented in each of the Array classes.

That will also allow us to give the indexed version a better name: updateKeyQuery()

We have instantiated FirestoreArray by its superclass references in Adapter classes. So, Will it be fine them to be instantiated as Array classes?

Fine 😃. Okay then 👍 .

I have some questions.

If I instantiate mSnapshots as FirebaseArray' as then how to take care of FirebaseIndexArray`?

How could we know that when to call updateQuery() or updateKeyQuery()?
In FirebaseRecyclerAdapter if I create an instance of FirebaseArray then we can't instantiate FirebaseIndexArray. How to do it?

Oh no that is a problem ... any ideas? I don't know why I am so opposed to adding updateQuery to the ObservabeSnapshotArray classes ... it just feels wrong. But maybe that is the best way.

I also thought a lot about it before implementation in ObservableSnapshotArray class. But I can't find anything helpful.

I had one idea. But that idea was not much good to implement. Means, it's not good practice to implement. I had idea to use instanceof to check whether it's instance of Firebase array or index array. We will check it in our method and by casting we will call array class method. That was the idea.

samtstern · 2019-07-23T16:29:44Z

        return oldItem.getKey().equals(newItem.getKey());
    }

+    @SuppressLint("DiffUtilEquals")


Why is this lint suppression added in this PR when nothing else about this file changed?

Because it caused an error when I run the command gradlew assembleDebug proguard-tests:build check

When I checked that class, it's showing me the red line under return statement showing a suggestion to add this line.

Ok I am fine with this, although I bet if we revert the unrelated changes in this PR, this will go away.

samtstern · 2019-07-23T16:31:34Z


 plugins {
    `kotlin-dsl`
+    kotlin("jvm") version "1.3.41"


Can you explain why we need all of these kotlin changes in this PR? Are they related?

No. I just updated it as it's on my system.

Ok let's revert these changes since they are not related to the feature.

samtstern · 2019-07-24T17:10:25Z

 distributionBase=GRADLE_USER_HOME
 distributionPath=wrapper/dists
-distributionUrl=https\://services.gradle.org/distributions/gradle-4.10.1-all.zip
+distributionUrl=https\://services.gradle.org/distributions/gradle-5.1.1-all.zip


Let's also revert this, this could be a big change and I want to do it separately (when I have time to verify the release process with gradle 5)

Change-Id: I3d6465a15171b2cd5629d93e5745585552129d2d

Change-Id: Iacc39b3b49d1b6e5ce753ee0ab3a11ac975b9de0

samtstern · 2019-07-25T18:54:36Z

@PatilShreyas ok I did some thinking and experimenting. First I found better words to explain myself :-) the reason I am not comfortable with updateQuery on ObservableSnapshotArray is because that class previous did not know that Query existed at all.

Second I think it may be better to structure this as setOptions where instead of just replacing the query you replace the whole options object you used to start the Adapter. Here's an example of how that might look (for RTDB only):
PatilShreyas#2

What do you think?

PatilShreyas · 2019-07-26T00:22:56Z

Right @samtstern!

[WIP] Update Query Experiments

PatilShreyas · 2019-07-30T02:36:21Z

@samtstern I have merged your PR and make changes as you suggested. Also implemented in Firestore adapter. Also, tested updateOptions on adapter.

samtstern · 2019-08-01T17:37:24Z

@PatilShreyas sorry I missed your last comment! Thanks for working with me on this, LGTM.

PatilShreyas · 2019-08-02T01:17:09Z

Anytime! Thank you!

PatilShreyas added 10 commits July 17, 2019 15:58

Updated gradle configuration and Kotlin version.

ef32c61

Updated gradle configuration and Kotlin version.

d4090e0

Added method updateQuery() in FirestoreRecyclerAdapter firebase#1614

79b914f

Added docs firebase#1614

0b50759

Added method updateQuery() in Realtime Database `FirebaseRecyclerAdap…

beaae22

…ter` firebase#1614

Added Doc in firebase#1614

76b735c

Merge branch 'version-5.0.1-dev' of https://github.com/firebase/Fireb…

9be735a

…aseUI-Android into sp-feature-1614

Merge remote-tracking branch 'origin/sp-feature-1614' into sp-feature…

e04bef3

…-1614

Fixed lint errors in Paging adapters.

c07fe9b

Added NonNull annotations in parameters of updateQuery() methods.

e6096b6

PatilShreyas requested a review from samtstern as a code owner July 20, 2019 14:27

samtstern added this to the 5.0.1 milestone Jul 23, 2019

samtstern reviewed Jul 23, 2019

View reviewed changes

samtstern reviewed Jul 24, 2019

View reviewed changes

Comment thread buildSrc/src/main/kotlin/Config.kt Outdated

samtstern reviewed Jul 24, 2019

View reviewed changes

PatilShreyas and others added 4 commits July 25, 2019 05:56

Reverted Changes

bfaebd4

Removed method from ObservableSnapshotArray

cb22591

Experiment with setOption() method

341e7a7

Change-Id: I3d6465a15171b2cd5629d93e5745585552129d2d

Mistake

8d73bf6

Change-Id: Iacc39b3b49d1b6e5ce753ee0ab3a11ac975b9de0

samtstern mentioned this pull request Jul 25, 2019

[WIP] Update Query Experiments PatilShreyas/FirebaseUI-Android#2

Merged

PatilShreyas added 3 commits July 30, 2019 07:15

Merge pull request #2 from firebase/ss-update-query-experiments

8d619d2

[WIP] Update Query Experiments

Merge by ss.

fad14e6

Updated code as suggestions.

16c5e2c

samtstern merged commit d7aec38 into firebase:version-5.0.1-dev Aug 1, 2019

Conversation

PatilShreyas commented Jul 20, 2019

Uh oh!

PatilShreyas commented Jul 20, 2019

Uh oh!

PatilShreyas commented Jul 22, 2019

Uh oh!

samtstern left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

PatilShreyas Jul 23, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

PatilShreyas Jul 25, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

PatilShreyas Jul 23, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

samtstern commented Jul 25, 2019

Uh oh!

PatilShreyas commented Jul 26, 2019

Uh oh!

PatilShreyas commented Jul 30, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

samtstern commented Aug 1, 2019

Uh oh!

PatilShreyas commented Aug 2, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

PatilShreyas Jul 23, 2019 •

edited

Loading

PatilShreyas Jul 25, 2019 •

edited

Loading

PatilShreyas Jul 23, 2019 •

edited

Loading

PatilShreyas commented Jul 30, 2019 •

edited

Loading