feat: Provider Models (AuthProvider + concrete types) #2223
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
demolaf
commented
Sep 24, 2025
| * which is required for security when upgrading anonymous users. Defaults to true. | ||
| */ | ||
|
|
||
| val isEmailLinkForceSameDeviceEnabled: Boolean = true, |
There was a problem hiding this comment.
this was a requirement and a config validation in the old auth library for EmailAuthProvider. When anonymous upgrade is enabled and email link is enabled, you must force same device for security purposes. here
demolaf
commented
Sep 24, 2025
auth/src/main/java/com/firebase/ui/auth/compose/configuration/AuthProvider.kt
Show resolved
Hide resolved
demolaf
commented
Sep 24, 2025
| ) | ||
| ) { | ||
| fun validate(context: Context) { | ||
| // TODO(demolaf): do we need this? since we are requesting this in AuthProvider.Google? |
There was a problem hiding this comment.
do we need to validate missing server client id?
There was a problem hiding this comment.
Was the validation done on the current version of the library?
There was a problem hiding this comment.
Yes but if you look reference in current version, when serverClientId is missing throws if not found during actual use.
demolaf
commented
Sep 24, 2025
auth/src/main/java/com/firebase/ui/auth/compose/configuration/AuthProvider.kt
Show resolved
Hide resolved
demolaf
commented
Sep 24, 2025
auth/src/main/java/com/firebase/ui/auth/compose/configuration/AuthProvider.kt
Outdated
Show resolved
Hide resolved
- validate serverClientId empty string - validate applicationId empty string - remove @test(expected=) not descriptive - tests covering AuthProviders Google and Facebook config validation
Lyokone
approved these changes
Sep 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.