Update issue and pull request templates #237
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PULL_REQUEST_TEMPLATE.md
Outdated
| @@ -0,0 +1,5 @@ | |||
| Hey there! So you want to contribute to FirebaseUI? Before you file this pull request, follow these steps: | |||
|
|
|||
| * Have you read [the contribution guidelines](CONTRIBUTING.md) | |||
There was a problem hiding this comment.
"Have you read the contribution guidelines?" (add punctuation)
Or, since it says "follow these steps" make it imperative: "Read the contribution guidelines."
|
One comment, otherwise LGTM. Also, glad that you're officially taking over for me (even though that was always the case). |
|
<3 LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@mcdonamp @puf please review