Add support for dark themes #367
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I figured out the text color propagation issue, this should work on all APIs. Tested on KitKat and Nougat |
|
LGTM. Thanks for digging into the theme madness. |
|
@amandle I'm seeing this bug now ("Firebase UI" is no longer centered in the action bar"):
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To solve issue #190 I had to change a bunch about the way the styles were set up. It now relies more heavily on the built-in attributes. The buttons are more standard material design buttons. There is, however, an issue with the textColor not propagating to the BodyText elements in API < 21 which I haven't figured out yet. If anyone has suggestions I'd love to get some feedback on this.