Skip to content

Make auth_method_picker layout work in landscape #562

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

samtstern
Copy link
Contributor

Issue #522

Landscape:
pick_landscape

Portrait:
pick_portrait

@samtstern
Copy link
Contributor Author

samtstern commented Jan 31, 2017

@SUPERCILEX take a look if you can. I chose not to go full ConstraintLayout since this was easy enough to solve the "normal" way and the addition of buttons at runtime makes things a little strange.

@SUPERCILEX
Copy link
Collaborator

@samtstern LGTM! Though isn't there a way we can use the include tag to do less copy pasting?

PS: I'm looking into the manifest thing for #559 so the Travis build will be happy after that.

Change-Id: Ic2aa65307e7b7851b3f1f0a6fb6cc3e735d31284
Change-Id: Ic6212b9df5a329370b02af804c44a778436c4ece
Change-Id: Icf58c89e1fc18923851f42aacede3dff009a7718
Change-Id: Id57e10b6cc81704e793227b396ed0d7a098dd5b7
@samtstern samtstern force-pushed the auth-method-picker-land branch from 81005f0 to 9ff7837 Compare January 31, 2017 22:41
Change-Id: Ie9a337263109aeb1a5fb8abe79bcd7da1cab3804
@SUPERCILEX
Copy link
Collaborator

@samtstern Looks like you need to merge from 1.2 dev to make the Travis builds pass.

@samtstern samtstern added this to the 1.2.0 milestone Jan 31, 2017
@samtstern samtstern merged commit 33b47d7 into firebase:version-1.2.0-dev Jan 31, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants