Support for Glide 4.0

[samtstern]

See #731

[WillieCubed]

Should this be static?

[samtstern]

Good call.

[akaSourav]

Change the Override method in GlideModule from

@Override
public void registerComponents(Context context, Registry registry) {
        registry.append(StorageReference.class, InputStream.class, new FirebaseImageLoader.Factory());
    }

to

@Override
public void registerComponents(Context context, Glide glide, Registry registry) {
        registry.append(StorageReference.class, InputStream.class, new FirebaseImageLoader.Factory());
    }

[samtstern]

@SUPERCILEX @TheCraftKid any objections to pushing this through for 3.0?

[samtstern]

@Sourav-21 can you explain your comment? That does not seem to be a valid override on AppGlideModule.

Edit: nevermind, worked out when I went to 4.1.1

[googlebot]

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that they're okay with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this State. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

[googlebot]

CLAs look good, thanks!

[WillieCubed]

LGTM!

[akaSourav]

Using GlideApp instead of Glide will be better.

[WillieCubed]

@Sourav-21 Is there a specific reason? The samples don't make that distinction.

[akaSourav]

With the generated API, the RequestOptions calls can be inlined:

GlideApp.with(fragment)
    .load(url)
    .centerCrop()
    .placeholder(R.drawable.placeholder)
    .error(R.drawable.error)
    .priority(Priority.HIGH)
    .into(imageView);

[SUPERCILEX]

@Sourav-21 I don't think you can add new load() methods with the generated API. In addition, you'll still be using it on your side—we just provide the loading mechanism.

@samtstern I'm not super familiar with providing loaders for Glide, but at a glance this LGTM. 😄

[akaSourav]

@SUPERCILEX I am just giving an example. load(storageRef) method with the generated API working fine.

[akaSourav]

With the release of Glide 4.1.1. I suggest the following changes
update Glide dependencies to 4.1.1 is
provided 'com.github.bumptech.glide:glide:4.1.1'

Change the GlideModule

@GlideModule
public class MyGlideModule extends AppGlideModule {
    @Override
    public void registerComponents(Context context, Glide glide, Registry registry) {
        registry.append(StorageReference.class, InputStream.class, new FirebaseImageLoader.Factory());
    }
}

And use GlideApp instead of Glide for simplicity.

GlideApp.with(fragment)
    .load(storageRef)
    .centerCrop()
    .into(imageView);

[SUPERCILEX]

Ohhhhh, I get it. You're suggesting simplifying the sample. Yeah @samtstern that's probably a good idea.

[akaSourav]

Yeah, I am suggesting you modify the demo. The changes @TheCraftKid has done with FirebaseImageLoader.java is great.

[samtstern]

@Sourav-21 thanks for the pointer about GlideApp.

I think this is ready to go now.