Make shadows have buttons on pre-L devices. #843
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See #842 Change-Id: Ifbb06228dae6cccdcc0a9a45656a1a2cae4ef805
SUPERCILEX
approved these changes
Aug 1, 2017
There was a problem hiding this comment.
@samtstern LGTM as long as this doesn't change the post-L look!
|
Oh, just saw #842 (comment). So yeah, awesome! 😄 |
|
@samtstern ooooooooooh, actually I think we can add some gradients! This StackOverflow post is for rounded corners but I think the same technique could apply. What do you think? 😀 |
|
@SUPERCILEX nice, I will try something like that. |
Change-Id: I8e4615bbd5acdea8508cbe5e32696d7624e6f0ed
|
@SUPERCILEX played with it for a little bit, none of the gradient types offered in XML drawables are suited for this. Linear gradients band out from the center, and the radial and sweep gradients just don't offer enough configuration to look good on a big rectangle. |
Change-Id: I66870fa42f61cf616317bf9083ec77200dabdce6
|
@samtstern oh well, we tried. 😀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #842
Before
After
