Skip to content

Fix DB and Firestore modules not working without common module #942

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Fix DB and Firestore modules not working without common module #942

wants to merge 1 commit into from

Conversation

SUPERCILEX
Copy link
Collaborator

@SUPERCILEX SUPERCILEX closed this Oct 3, 2017
@SUPERCILEX
Copy link
Collaborator Author

@samtstern Hmmm, JitPack is broken without the common module. I have no idea how the POM stuff works, but does just adding the common module to the library work? Or are you working on another solution?

PS: if the firebase-ui dep is broken without the common module, I think we should either kill it or publish the common module.

@SUPERCILEX SUPERCILEX reopened this Oct 3, 2017
@SUPERCILEX
Copy link
Collaborator Author

Nevermind, I've seen #944.

@SUPERCILEX SUPERCILEX closed this Oct 3, 2017
@SUPERCILEX SUPERCILEX deleted the patch-1 branch October 9, 2017 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@SUPERCILEX