Change static library targets to dynamic framework targets #115
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
morganchen12
force-pushed
the
dylibs
branch
5 times, most recently
from
d4f0834 to
b0d6e18
Compare
|
Looks like we won't need to strip slices out because of CocoaPods magic. This PR now mostly works now: the |
morganchen12
changed the title
FirebaseUI.podspec
Outdated
| s.author = 'Firebase' | ||
| s.source = { :http => 'https://dl.google.com/dl/firebase/firebaseui/ios/0_5_0/FirebaseUIFrameworks.zip' } | ||
| # s.source = { :http => 'https://dl.google.com/dl/firebase/firebaseui/ios/0_5_0/FirebaseUIFrameworks.zip' } | ||
| s.source = { :http => 'http://localhost:7777/FirebaseUIFrameworks.zip' } |
There was a problem hiding this comment.
Is this an intentional check in?
There was a problem hiding this comment.
Also, you should talk to @yramanchuk about his changes here for local development.
README.md
Outdated
| [](https://travis-ci.org/firebase/FirebaseUI-iOS) | ||
|
|
||
| FirebaseUI is an open-source library for iOS that allows you to quickly connect common UI elements to the [Firebase](https://firebase.google.com?utm_campaign=Firebase_update_awareness_general_en_05-18-16_&utm_source=?utm_campaign=Firebase_featureoverview_awareness_analytics_en_05-18-16_&utm_source=?utm_campaign=Firebase_announcement_awareness_general_en_05-18-16_&utm_source=Firebase&utm_medium=ads&utm_medium=?utm_campaign=Firebase_announcement_awareness_general_en_05-18-16_&utm_source=Firebase&utm_medium=ads&utm_medium=?utm_campaign=Firebase_update_awareness_auth_en_05-18-16_&utm_source=?utm_campaign=Firebase_announcement_awareness_general_en_05-18-16_&utm_source=Firebase&utm_medium=ads&utm_medium=?utm_campaign=Firebase_featureoverview_awareness_analytics_en_05-18-16_&utm_source=?utm_campaign=Firebase_announcement_awareness_general_en_05-18-16_&utm_source=Firebase&utm_medium=ads&utm_medium=?utm_campaign=Firebase_announcement_awareness_general_en_05-18-16_&utm_source=Firebase&utm_medium=ads) database for data storage, allowing views to be updated in realtime as they change, and providing simple interfaces for common tasks like displaying lists or collections of items. | ||
| FirebaseUI is an open-source library for iOS that allows you to quickly connect common UI elements to the [Firebase](https://firebase.google.com) database for data storage, allowing views to be updated in realtime as they change, and providing simple interfaces for common tasks like displaying lists or collections of items. |
There was a problem hiding this comment.
Sweet mother of UTM campaigns. Let's keep a utm_source=FirebaseUI-iOS at the minimum... (but yeah, who added the other ones?)
morganchen12
force-pushed
the
dylibs
branch
2 times, most recently
from
9bac4c1 to
3c61ee1
Compare
|
Tests pass! Quick, merge while no one is looking |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously our assets weren't bundled with the static libs we were building, meaning in order to release anything we'd have to bundle them manually.
This PR doesn't solve everything--the dylibs need to be
lipod to run on both simulator and device, and then they need to be unlipod (and codesigned) when embedding them in the product since the App Store rejects apps that link against fat dylibs.