feat: google reauthenticate logic for sensitive operations such as delete user #1258
Conversation
| Button(action: { | ||
| withAnimation { | ||
| switchFlow() | ||
| ScrollView { |
There was a problem hiding this comment.
Just added ScrollView here. Otherwise, cannot see all options.
| } | ||
|
|
||
| extension GoogleOperationReauthentication { | ||
| @MainActor func reauthenticate() async throws -> AuthenticationToken { |
There was a problem hiding this comment.
Follows near identical logic to Facebook for reauthentication.
| try await self.signInWithGoogle(clientID: self.clientID) | ||
| } | ||
| }) | ||
| AnyView(SignInWithGoogleButton()) |
There was a problem hiding this comment.
Moved this into separate View, it was directly calling signInWithGoogle which meant it wasn't actually signing in with Firebase and not using AuthService to update currentUser and other aspects of state.
There was a problem hiding this comment.
Consider documenting this in a comment since it's unintuitive looking at the code.
| try await operation(on: user) | ||
| } else if providerId == "facebook.com" { | ||
| try await facebookProvider.deleteUser(user: user) | ||
| } else if providerId == "google.com" { |
There was a problem hiding this comment.
These string values should be vended by the upstream Auth SDK as constants if you'd like to use those instead of typing them out: https://firebase.google.com/docs/reference/ios/firebaseauth/api/reference/Constants#firgoogleauthproviderid
| try await self.signInWithGoogle(clientID: self.clientID) | ||
| } | ||
| }) | ||
| AnyView(SignInWithGoogleButton()) |
There was a problem hiding this comment.
Consider documenting this in a comment since it's unintuitive looking at the code.
2 participants
Made some comments for ease of understanding.